Skip to content

feat(cli): print working dir in grey in stack traces, relative paths in check + compile output #31194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat(cli): print working dir in grey in stack traces, relative paths in check + compile output #31194

wants to merge 7 commits into from
+212 −100

Conversation

@nathanwhit
Copy link
Member

@nathanwhit nathanwhit commented Nov 5, 2025

Before:
Screenshot 2025-11-05 at 11 43 03 AM

After:

Screenshot 2025-11-05 at 11 44 39 AM

@nathanwhit nathanwhit changed the title feat(cli): print working dir in grey in stack traces feat(cli): print working dir in grey in stack traces, relative paths in check + compile output Nov 5, 2025
@nathanwhit nathanwhit enabled auto-merge (squash) November 5, 2025 13:25
dsherret
dsherret approved these changes Nov 5, 2025
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry
Copy link
Member

ry commented Nov 6, 2025

what about eliding the file// prefix?

@bartlomieju
Copy link
Member

bartlomieju commented Nov 6, 2025

We can try to tackle that in a follow up

@dsherret
Copy link
Member

dsherret commented Nov 6, 2025 •
edited
Loading

FWIW, changing from file: urls to paths, would make dealing with windows paths a little annoying in the tests. For example, right now we just do file:///[WILDLINE]/some/file.ts, but if we moved away from file urls we'd have to have it handle either \ or /

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nathanwhit @ry @bartlomieju @dsherret